Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: test colcon-build action that disables internet access #4375

Closed

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jul 23, 2023

Description

This PR is just a test to make sure that autowarefoundation/autoware-github-actions#241 works.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jul 23, 2023
@esteve esteve marked this pull request as ready for review July 24, 2023 14:24
@esteve esteve marked this pull request as draft July 24, 2023 14:24
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 24, 2023
@esteve
Copy link
Contributor Author

esteve commented Jul 24, 2023

@miursh @yukkysaito please don't review this PR, it's just a test for autowarefoundation/autoware-github-actions#241

esteve added 3 commits July 24, 2023 16:41
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the ci-disable-internet-during-build branch from 4e539a8 to 987ee71 Compare July 24, 2023 14:41
@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 31, 2023
@miursh
Copy link
Contributor

miursh commented Oct 13, 2023

@esteve Do we need to keep this PR? Otherwise, I will close this PR if possible.

@esteve
Copy link
Contributor Author

esteve commented Nov 2, 2023

@miursh we don't need it anymore, it was just a test. And autowarefoundation/autoware-github-actions#241 is now merged. Closing this PR now. Thanks for the reminder.

@esteve esteve closed this Nov 2, 2023
@esteve esteve deleted the ci-disable-internet-during-build branch November 2, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants