Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(roi_cluster_fusion): update default value of only_allow_inside_cluster is true #4212

Merged

Conversation

ktro2828
Copy link
Contributor

Description

update default value of only_allow_inside_cluster is true in image_projection_based_fusion/roi_cluster_fusion

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…cluster` is `true`

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 self-assigned this Jul 10, 2023
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 10, 2023
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktro2828 ktro2828 enabled auto-merge (squash) July 10, 2023 06:49
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (8c982e5) 14.16% compared to head (b3666af) 14.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4212      +/-   ##
==========================================
+ Coverage   14.16%   14.18%   +0.01%     
==========================================
  Files        1586     1586              
  Lines      109537   109350     -187     
  Branches    31451    31353      -98     
==========================================
- Hits        15518    15512       -6     
+ Misses      77130    76965     -165     
+ Partials    16889    16873      -16     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.18% <ø> (+0.01%) ⬆️ Carriedforward from 8c982e5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r4_planning_rviz_plugin/src/tools/max_velocity.cpp 0.00% <ø> (ø)
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% <0.00%> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...nner/scene_module/lane_change/external_request.hpp 0.00% <ø> (ø)
...ath_planner/scene_module/lane_change/interface.hpp 100.00% <ø> (+50.00%) ⬆️
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 27.23% <ø> (+0.25%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 11.52% <ø> (+0.01%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 6.06% <ø> (+0.09%) ⬆️
... and 13 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ktro2828 ktro2828 merged commit 5605b19 into autowarefoundation:main Jul 10, 2023
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jul 10, 2023
…cluster` is `true` (autowarefoundation#4212)

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 deleted the feat/check-inside-default branch April 2, 2024 18:04
SaltUhey pushed a commit to SaltUhey/autoware.universe that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants