-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(roi_cluster_fusion): update default value of only_allow_inside_cluster
is true
#4212
feat(roi_cluster_fusion): update default value of only_allow_inside_cluster
is true
#4212
Conversation
…cluster` is `true` Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4212 +/- ##
==========================================
+ Coverage 14.16% 14.18% +0.01%
==========================================
Files 1586 1586
Lines 109537 109350 -187
Branches 31451 31353 -98
==========================================
- Hits 15518 15512 -6
+ Misses 77130 76965 -165
+ Partials 16889 16873 -16
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…cluster` is `true` (autowarefoundation#4212) Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
…foundation#4212) Signed-off-by: Berkay Karaman <brkay54@gmail.com>
Description
update default value of
only_allow_inside_cluster
istrue
inimage_projection_based_fusion/roi_cluster_fusion
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.