Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): update lane change object filter #4172

Merged
merged 5 commits into from
Jul 5, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jul 5, 2023

Description

With the current lane change object filter, it does safety checks with the objects that are behind the ego vehicle on the current lane. However, this can cause false positive problem, so in this PR, I filtered the unnecessary objects.

Tests performed

PSim
Screencast from 07-05-2023 02:25:26 PM.webm

Scenario Test
1574/1579
TierIV Internal LInk

Effects on system behavior

Ego vehicle is going to ignore the objects that are behind itself on the current lanes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (18fdbef) 14.30% compared to head (728e681) 14.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4172   +/-   ##
=======================================
  Coverage   14.30%   14.31%           
=======================================
  Files        1571     1571           
  Lines      108372   108321   -51     
  Branches    31374    31376    +2     
=======================================
  Hits        15503    15503           
+ Misses      76017    75966   -51     
  Partials    16852    16852           
Flag Coverage Δ *Carryforward flag
differential 13.49% <0.00%> (?)
total 14.31% <ø> (+<0.01%) ⬆️ Carriedforward from 18fdbef

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ization/ndt_scan_matcher/src/map_update_module.cpp 0.00% <ø> (ø)
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <ø> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.89% <0.00%> (ø)
...avior_path_planner/src/utils/lane_change/utils.cpp 0.40% <0.00%> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit 58b2044 into main Jul 5, 2023
@purewater0901 purewater0901 deleted the feat/update-lc-object-filter branch July 5, 2023 09:15
purewater0901 added a commit to tier4/autoware.universe that referenced this pull request Jul 5, 2023
…on#4172)

* feat(lane_change): update lane change object filter

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901 added a commit to tier4/autoware.universe that referenced this pull request Jul 5, 2023
…on#4172)

* feat(lane_change): update lane change object filter

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants