-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): update lane change object filter #4172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yutaka <purewater0901@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4172 +/- ##
=======================================
Coverage 14.30% 14.31%
=======================================
Files 1571 1571
Lines 108372 108321 -51
Branches 31374 31376 +2
=======================================
Hits 15503 15503
+ Misses 76017 75966 -51
Partials 16852 16852
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
rej55
approved these changes
Jul 5, 2023
purewater0901
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 5, 2023
…on#4172) * feat(lane_change): update lane change object filter Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 5, 2023
…on#4172) * feat(lane_change): update lane change object filter Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the current lane change object filter, it does safety checks with the objects that are behind the ego vehicle on the current lane. However, this can cause false positive problem, so in this PR, I filtered the unnecessary objects.
Tests performed
PSim
Screencast from 07-05-2023 02:25:26 PM.webm
Scenario Test
1574/1579
TierIV Internal LInk
Effects on system behavior
Ego vehicle is going to ignore the objects that are behind itself on the current lanes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.