Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename traffic signal element #4129

Merged
merged 10 commits into from
Jul 5, 2023
Merged

feat: rename traffic signal element #4129

merged 10 commits into from
Jul 5, 2023

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Jun 30, 2023 •
edited
Loading

Description

Update for autowarefoundation/autoware_msgs#70.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi
feat(traffic_light_arbiter): rename traffic signal element
06fe137 
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi requested review from knzo25 and a team as code owners June 30, 2023 08:04
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 30, 2023
@isamu-takagi isamu-takagi marked this pull request as draft June 30, 2023 08:18
@isamu-takagi
feat(traffic_light_selector): remove traffic light selector
4deb4db 
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi
fix(traffic_light_arbiter): fix node name
27dafe4 
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Jun 30, 2023
@isamu-takagi isamu-takagi changed the title feat(traffic_light_arbiter): rename traffic signal element feat: remove traffic light selector Jun 30, 2023
@isamu-takagi isamu-takagi changed the title feat: remove traffic light selector feat(traffic_light_arbiter): rename traffic signal element Jun 30, 2023
@isamu-takagi isamu-takagi self-assigned this Jun 30, 2023
@knzo25
Copy link
Contributor

knzo25 commented Jul 5, 2023

Since the former traffic_light_selector does not exist anymore, I think the launcher should change the input topic:

From:

<remap from="~/sub/perception_traffic_signals" to="/perception/traffic_light_selector/traffic_signals"/>

to:

<remap from="~/sub/perception_traffic_signals" to="/perception/traffic_light_recognition/traffic_signals"/>

@isamu-takagi isamu-takagi marked this pull request as ready for review July 5, 2023 06:23
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Jul 5, 2023
@isamu-takagi
Copy link
Contributor Author

Since the former traffic_light_selector does not exist anymore, I think the launcher should change the input topic:

Updated 5344868

knzo25
knzo25 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

knzo25 and others added 4 commits July 5, 2023 16:05
@knzo25
Merge branch 'main' into feat/rename-traffic-signal-element
c49d95e
@isamu-takagi
update message type
5e00644 
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi
update message type
5430745 
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi
Merge branch 'feat/rename-traffic-signal-element' of github.com:isamu…
d57011c 
…-takagi/autoware.universe into feat/rename-traffic-signal-element
@isamu-takagi isamu-takagi requested a review from yukkysaito as a code owner July 5, 2023 08:14
@isamu-takagi isamu-takagi changed the title feat(traffic_light_arbiter): rename traffic signal element feat: rename traffic signal element Jul 5, 2023
Mingyu1991
Mingyu1991 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@Mingyu1991 Mingyu1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6f11675) 15.23% compared to head (d57011c) 15.23%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4129   +/-   ##
=======================================
  Coverage   15.23%   15.23%           
=======================================
  Files        1468     1468           
  Lines      101728   101727    -1     
  Branches    31374    31374           
=======================================
  Hits        15503    15503           
+ Misses      69373    69372    -1     
  Partials    16852    16852
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.24% <ø> (+<0.01%) ⬆️ Carriedforward from 6f11675

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% <ø> (ø)
...age_projection_based_fusion/src/utils/geometry.cpp 0.00% <ø> (ø)
...raffic_light_arbiter/src/traffic_light_arbiter.cpp 0.00% <0.00%> (ø)
...ion/traffic_light_multi_camera_fusion/src/node.cpp 0.00% <0.00%> (ø)
...lization/src/traffic_light_map_visualizer/node.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@isamu-takagi isamu-takagi merged commit dd6cd80 into autowarefoundation:main Jul 5, 2023
@isamu-takagi isamu-takagi deleted the feat/rename-traffic-signal-element branch July 5, 2023 09:48
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 5, 2023
Merged
saka1-s pushed a commit to tier4/autoware.universe that referenced this pull request Jul 18, 2023
@isamu-takagi @knzo25 @saka1-s
feat: rename traffic signal element (autowarefoundation#4129)
97e0ffb 
* feat(traffic_light_arbiter): rename traffic signal element

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(traffic_light_selector): remove traffic light selector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix(traffic_light_arbiter): fix node name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update topic name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Jul 21, 2023
@isamu-takagi @knzo25 @TomohitoAndo
feat: rename traffic signal element (autowarefoundation#4129)
248defe 
* feat(traffic_light_arbiter): rename traffic signal element

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(traffic_light_selector): remove traffic light selector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix(traffic_light_arbiter): fix node name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update topic name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo mentioned this pull request Jul 21, 2023
Merged
4 tasks
@saka1-s saka1-s mentioned this pull request Jul 21, 2023
Merged
4 tasks
saka1-s added a commit to tier4/autoware.universe that referenced this pull request Jul 25, 2023
@saka1-s @Mingyu1991
@miursh @isamu-takagi @manato @knzo25
chore: update traffic light message of perception modules (#677)
d8ae8b7 
* feat(traffic_light_occlusion_predictor): add traffic_light_occlusion_predictor (autowarefoundation#4050)

* add traffic_light_occlusion_predictor

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

* update README

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

* update occlusion package I/F

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

* revert wrong update of README.md

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

* update perception_utils

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

* add _deg to variables and update README

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

* fix Cmakelists

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

---------

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* feat(traffic_light_classifier): update traffic_light_classifier and traffic_light_fine_detector (autowarefoundation#4125)

* first commit

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

* fix typo

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

* Revert unnecessary changes

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* change to fit previous revert

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* fix: correct style

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

* fix: use proper initializer

Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>

* fix build_config constructor

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* pre-commit

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

---------

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
Co-authored-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>

* feat(traffic_light_selector): remove traffic light selector (autowarefoundation#4130)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(traffic_light): improved traffic_light_map_based_detector and new traffic_light_fine_detector package (autowarefoundation#4084)

* update traffic_light_map_based_detector traffic_light_classifier traffic_light_fine_detector traffic_light_multi_camera_fusion

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

* replace autoware_auto_perception_msgs with tier4_perception_msgs

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

---------

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>

* feat: rename traffic signal element (autowarefoundation#4129)

* feat(traffic_light_arbiter): rename traffic signal element

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(traffic_light_selector): remove traffic light selector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix(traffic_light_arbiter): fix node name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update topic name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>

---------

Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: Mingyu1991 <115005477+Mingyu1991@users.noreply.github.com>
Co-authored-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Jul 25, 2023
@TomohitoAndo @isamu-takagi @knzo25
feat(behavior_velocity): support the new traffic signal interface (#675)
014a92c 
* feat(behavior_velocity): support new traffic signal interface

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

style(pre-commit): autofix

add missing dependency

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

style(pre-commit): autofix

remove the external signal input source in behavior_planning_launch.py

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

replace TrafficLightElement with TrafficSignalElement

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

style(pre-commit): autofix

use the regulatory element id instead of traffic light id

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

change the input of traffic signal to traffic light arbiter

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

do not return until the all regulatory elements are checked

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* docs(traffic_light_arbiter): fix the datatype of input topics (autowarefoundation#4156)

docs(traffic_light_arbiter): fix the type of input topics

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat: rename traffic signal element (autowarefoundation#4129)

* feat(traffic_light_arbiter): rename traffic signal element

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(traffic_light_selector): remove traffic light selector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix(traffic_light_arbiter): fix node name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update topic name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* update message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat(traffic_light_selector): remove traffic light selector (autowarefoundation#4130)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knzo25 knzo25 knzo25 approved these changes

@Mingyu1991 Mingyu1991 Mingyu1991 approved these changes

@miursh miursh Awaiting requested review from miursh

@yukkysaito yukkysaito Awaiting requested review from yukkysaito

Assignees

@isamu-takagi isamu-takagi

Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isamu-takagi @knzo25 @Mingyu1991