Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): do not plan if detection area is not empty and stop line idx is 0 #4097

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jun 27, 2023

Description

If ego vehicle is already in the middle of the intersection, do not generate stop line at the beginning of the path.

Related links

FOO COMPANY INTERNAL LINK

Tests performed

before this PR

image

After this PR

image

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 27, 2023
@soblin soblin marked this pull request as ready for review June 27, 2023 12:24
@soblin soblin requested review from shmpwk, takayuki5168, tkimura4 and a team as code owners June 27, 2023 12:24
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the fix/intersection-behind-stopline branch from c49ec98 to 12b3ae7 Compare June 27, 2023 12:35
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (6f5af96) 14.35% compared to head (12b3ae7) 14.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4097      +/-   ##
==========================================
- Coverage   14.35%   14.35%   -0.01%     
==========================================
  Files        1567     1567              
  Lines      107850   107851       +1     
  Branches    31231    31233       +2     
==========================================
  Hits        15487    15487              
- Misses      75523    75524       +1     
  Partials    16840    16840              
Flag Coverage Δ *Carryforward flag
differential 7.69% <0.00%> (?)
total 14.36% <ø> (+<0.01%) ⬆️ Carriedforward from 6f5af96

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.31% <ø> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.83% <ø> (+<0.01%) ⬆️
planning/behavior_path_planner/src/utils/utils.cpp 15.33% <ø> (+0.01%) ⬆️
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soblin soblin merged commit df8a43a into autowarefoundation:main Jun 28, 2023
@soblin soblin deleted the fix/intersection-behind-stopline branch June 28, 2023 04:32
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Jun 28, 2023
…p line idx is 0 (autowarefoundation#4097)

do not plan if detection area is not empty and stop line idx is 0

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Jun 29, 2023
…p line idx is 0 (autowarefoundation#4097)

do not plan if detection area is not empty and stop line idx is 0

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 18, 2023
…p line idx is 0 (autowarefoundation#4097) (#631)

fix(intersection): do not plan if detection area is not empty and stop line idx is 0 (autowarefoundation#4097)

do not plan if detection area is not empty and stop line idx is 0

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants