Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(behavior_path_planner): add documentation for avoidance by lane change module #4087

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jun 27, 2023

Description

Add documentation for avoidance by lane change module.

Tests performed

Nothing.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 27, 2023
@satoshi-ota satoshi-ota added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) component:planning Route planning, decision-making, and navigation. (auto-assigned) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 27, 2023
…change module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the docs/avoidance-by-lc branch from 7817db2 to 2b4d81f Compare June 27, 2023 00:39
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3e12df8) 15.29% compared to head (2b4d81f) 15.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4087   +/-   ##
=======================================
  Coverage   15.29%   15.29%           
=======================================
  Files        1461     1461           
  Lines      101215   101215           
  Branches    31215    31215           
=======================================
  Hits        15482    15482           
  Misses      68897    68897           
  Partials    16836    16836           
Flag Coverage Δ *Carryforward flag
differential 13.58% <ø> (?)
total 15.29% <ø> (ø) Carriedforward from 3e12df8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

| Name | Unit | Type | Description | Default value |
| :------------------------------------------------- | ---- | ------ | ---------------------------------------------------------------------------------------------------------------------------------------- | ------------- |
| execute_object_num | [-] | int | Number of avoidance target objects on ego driving lane is greater than this value, this module will be launched. | 1 |
| execute_object_longitudinal_margin | [m] | double | [maybe unused] Only when distance between the ego and avoidance target object is longer than this value, this module will be launched. | 0.0 |
Copy link
Contributor

@tkimura4 tkimura4 Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[maybe unused] <- Is this intentional?

Copy link
Contributor Author

@satoshi-ota satoshi-ota Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Yes. But I'll remove this parameter.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (If the above one is no problem)

@satoshi-ota satoshi-ota merged commit 0e733cd into autowarefoundation:main Jun 27, 2023
@satoshi-ota satoshi-ota deleted the docs/avoidance-by-lc branch June 27, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants