-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): add param for a lateral distance margin where the abort can be performed #4083
feat(lane_change): add param for a lateral distance margin where the abort can be performed #4083
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
planning/behavior_path_planner/config/lane_change/lane_change.param.yaml
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4083 +/- ##
==========================================
- Coverage 15.29% 14.36% -0.94%
==========================================
Files 1461 1566 +105
Lines 101218 108238 +7020
Branches 31216 31649 +433
==========================================
+ Hits 15484 15545 +61
- Misses 68899 75815 +6916
- Partials 16835 16878 +43
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…abort can be performed (autowarefoundation#4083) * feat(lane_change): add param for abort execution margin Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix for merge Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix doc Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…abort can be performed (autowarefoundation#4083) * feat(lane_change): add param for abort execution margin Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix for merge Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix doc Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…abort can be performed (autowarefoundation#4083) * feat(lane_change): add param for abort execution margin Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix for merge Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix doc Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
Add a parameter for the "abort" execution. If the ego is over the lane with the given threshold, abort will not be performed.
launcher: autowarefoundation/autoware_launch#421
Related links
None
Tests performed
Run Psim.
In the video below, the debug marker is temporally visualized. The "abort" can be performed when the polygon is green, and prohibited when it is red.
With margin = 0.0
lc-abort-check-margin-0-.2023-06-26-18-21-38.mp4
With margin = 1.0
lc-abort-check-margin-1-.2023-06-26-18-23-21.mp4
Note: the computing time changes slightly.
0.019[ms]
->0.030[ms]
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.