Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): add param for a lateral distance margin where the abort can be performed #4083

Merged
merged 6 commits into from
Jun 27, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jun 26, 2023

Description

Add a parameter for the "abort" execution. If the ego is over the lane with the given threshold, abort will not be performed.

launcher: autowarefoundation/autoware_launch#421

Related links

None

Tests performed

Run Psim.

In the video below, the debug marker is temporally visualized. The "abort" can be performed when the polygon is green, and prohibited when it is red.

With margin = 0.0

lc-abort-check-margin-0-.2023-06-26-18-21-38.mp4

With margin = 1.0

lc-abort-check-margin-1-.2023-06-26-18-23-21.mp4

Note: the computing time changes slightly. 0.019[ms] -> 0.030[ms]

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 26, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe changed the title feat(lane_change): add param for abort execution margin feat(lane_change): add param for a lateral distance margin where the abort can be performed Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.94 ⚠️

Comparison is base (084c7e2) 15.29% compared to head (ff70591) 14.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4083      +/-   ##
==========================================
- Coverage   15.29%   14.36%   -0.94%     
==========================================
  Files        1461     1566     +105     
  Lines      101218   108238    +7020     
  Branches    31216    31649     +433     
==========================================
+ Hits        15484    15545      +61     
- Misses      68899    75815    +6916     
- Partials    16835    16878      +43     
Flag Coverage Δ *Carryforward flag
differential 13.57% <0.00%> (?)
total 14.37% <ø> (-0.93%) ⬇️ Carriedforward from 5e655cc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 16.27% <0.00%> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.29% <0.00%> (-0.08%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 3.81% <0.00%> (-1.02%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 15.29% <0.00%> (-0.03%) ⬇️

... and 117 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Jun 27, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe merged commit 3fea24f into autowarefoundation:main Jun 27, 2023
@TakaHoribe TakaHoribe deleted the abort-lateral-threshold branch June 27, 2023 10:14
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 29, 2023
…abort can be performed (autowarefoundation#4083)

* feat(lane_change): add param for abort execution margin

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix for merge

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* update readme

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix doc

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

---------

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 4, 2023
…abort can be performed (autowarefoundation#4083)

* feat(lane_change): add param for abort execution margin

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix for merge

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* update readme

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix doc

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

---------

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 5, 2023
…abort can be performed (autowarefoundation#4083)

* feat(lane_change): add param for abort execution margin

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix for merge

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* update readme

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix doc

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

---------

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants