Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): enrich lane change debug markers #4076

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Jun 26, 2023

Description

There has been several updates in lane change module, so this PR aims to improve lane change debug markers information.

Related links

N/A

Tests performed

Follow the steps as describe here

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 26, 2023
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 9.83% and project coverage change: -0.01 ⚠️

Comparison is base (a3c6ea2) 14.36% compared to head (e984aa2) 14.36%.

❗ Current head e984aa2 differs from pull request most recent head 560ecc3. Consider uploading reports for the commit 560ecc3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4076      +/-   ##
==========================================
- Coverage   14.36%   14.36%   -0.01%     
==========================================
  Files        1566     1566              
  Lines      107727   107769      +42     
  Branches    31176    31206      +30     
==========================================
+ Hits        15478    15481       +3     
- Misses      75421    75454      +33     
- Partials    16828    16834       +6     
Flag Coverage Δ *Carryforward flag
differential 13.63% <9.83%> (?)
total 14.36% <ø> (+<0.01%) ⬆️ Carriedforward from 3220d3f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...avior_path_planner/marker_util/debug_utilities.hpp 0.00% <ø> (ø)
...path_planner/src/marker_util/lane_change/debug.cpp 0.00% <0.00%> (ø)
...planner/src/scene_module/lane_change/interface.cpp 5.53% <0.00%> (-0.02%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 4.39% <0.00%> (-0.01%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.44% <0.00%> (ø)
...g/behavior_path_planner/src/utils/safety_check.cpp 29.85% <20.00%> (+1.72%) ⬆️
...g/behavior_path_planner/test/test_safety_check.cpp 42.50% <33.33%> (-2.38%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Jun 26, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review June 26, 2023 10:18
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 6f5af96 into autowarefoundation:main Jun 27, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-lane-change-debug branch June 27, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants