Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): set additional buffer margin independently #4041

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jun 22, 2023

Description

Avoidance shift length can be set independently for each object classes.

Please approve ⬇️ before this PR.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (7b6bff2) 14.37% compared to head (f3d877c) 14.37%.

❗ Current head f3d877c differs from pull request most recent head 6e15600. Consider uploading reports for the commit 6e15600 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4041      +/-   ##
==========================================
- Coverage   14.37%   14.37%   -0.01%     
==========================================
  Files        1566     1566              
  Lines      107726   107725       -1     
  Branches    31175    31176       +1     
==========================================
- Hits        15482    15481       -1     
+ Misses      75420    75419       -1     
- Partials    16824    16825       +1     
Flag Coverage Δ *Carryforward flag
differential 13.64% <0.00%> (?)
total 14.37% <ø> (-0.01%) ⬇️ Carriedforward from edcad42

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.44% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 11.68% <0.00%> (ø)
...ath_planner/src/scene_module/avoidance/manager.cpp 14.28% <0.00%> (ø)
...ehavior_path_planner/src/utils/avoidance/utils.cpp 5.81% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota force-pushed the feat/set-collision-margin-independently branch from d7bbc4f to f3d877c Compare June 24, 2023 08:17
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Jun 24, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review June 25, 2023 23:57
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/set-collision-margin-independently branch from f3d877c to 6e15600 Compare June 26, 2023 00:10
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Jun 26, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) June 26, 2023 00:53
@satoshi-ota satoshi-ota merged commit a3c6ea2 into autowarefoundation:main Jun 26, 2023
@satoshi-ota satoshi-ota deleted the feat/set-collision-margin-independently branch June 26, 2023 01:22
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants