Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): skip unnecessary process in updateDate() when module_status is not RUNNING #4031

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jun 21, 2023

Description

skip unnecessary process in updateDate() when module_status is not RUNNING.
But requested_lateral_offset_ should be updated to judge whether execution is excecuted.
So the part of retriving requested_lateral_offset_ is kept.

confirmed with psim

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 21, 2023
@kyoichi-sugahara kyoichi-sugahara changed the title fix(behavior_path_planner): fix access error when side shift is not requested fix(behavior_path_planner): skip unnecessary process in updateDate() when module_status is not RUNNING Jun 21, 2023
…NNING

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…NNING

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (80b2ae4) 15.41% compared to head (3fabdb9) 15.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4031      +/-   ##
==========================================
- Coverage   15.41%   15.41%   -0.01%     
==========================================
  Files        1356     1356              
  Lines       96414    96416       +2     
  Branches    29902    29903       +1     
==========================================
  Hits        14864    14864              
- Misses      65312    65314       +2     
  Partials    16238    16238              
Flag Coverage Δ *Carryforward flag
differential 12.70% <0.00%> (?)
total 15.41% <ø> (ø) Carriedforward from 49901a8

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../src/scene_module/side_shift/side_shift_module.cpp 9.72% <0.00%> (-0.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kyoichi-sugahara kyoichi-sugahara merged commit 6dc708c into autowarefoundation:main Jun 22, 2023
@kyoichi-sugahara kyoichi-sugahara deleted the fix/sideshift_access_error branch October 31, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants