Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start_planner): add length_ratio_for_turn_signal_deactivation_near_intersection #4026

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

kosuke55
Copy link
Contributor

Description

add length_ratio_for_turn_signal_deactivation_near_intersection to offset requreid end pose of start planner if vehicle is near intersection.
This is to give priority to that signal near intersections.

start_planner_intersection_blinker-2023-06-20_21.48.44.mp4

Related links

tier4 internal slack

Tests performed

psim

Notes for reviewers

none

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ar_intersection

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/start_planner_blinker_desired_end_pose_ration branch from f1313ba to 27a27f0 Compare June 20, 2023 12:57
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (6e7d163) 14.43% compared to head (5c31ee3) 14.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4026      +/-   ##
==========================================
- Coverage   14.43%   14.43%   -0.01%     
==========================================
  Files        1462     1462              
  Lines      102963   102989      +26     
  Branches    29876    29892      +16     
==========================================
  Hits        14866    14866              
- Misses      71864    71886      +22     
- Partials    16233    16237       +4     
Flag Coverage Δ *Carryforward flag
differential 12.72% <0.00%> (?)
total 14.43% <ø> (+<0.01%) ⬆️ Carriedforward from 6e7d163

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r/utils/start_planner/start_planner_parameters.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.24% <0.00%> (-0.09%) ⬇️
...cene_module/start_planner/start_planner_module.cpp 5.83% <0.00%> (-0.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 80b2ae4 into main Jun 21, 2023
@kosuke55 kosuke55 deleted the feat/start_planner_blinker_desired_end_pose_ration branch June 21, 2023 04:18
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Jun 21, 2023
…ar_intersection (autowarefoundation#4026)

* feat(start_planner): add length_ratio_for_turn_signal_deactivation_near_intersection

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Jun 21, 2023
…ar_intersection (autowarefoundation#4026)

* feat(start_planner): add length_ratio_for_turn_signal_deactivation_near_intersection

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
j4tfwm6z pushed a commit to tier4/autoware.universe that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants