feat(detected_object_validation): add BOUNDING_BOX interface to lanelet filter #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nelet filter Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3957 +/- ##
==========================================
- Coverage 14.45% 14.45% -0.01%
==========================================
Files 1456 1456
Lines 102537 102550 +13
Branches 29652 29652
==========================================
Hits 14819 14819
- Misses 71567 71580 +13
Partials 16151 16151
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
yukkysaito
reviewed
Jun 13, 2023
perception/detected_object_validation/src/object_lanelet_filter.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: scepter914 <scepter914@gmail.com>
zulfaqar-azmi-t4
pushed a commit
to zulfaqar-azmi-t4/autoware.universe
that referenced
this pull request
Jun 21, 2023
…et filter (autowarefoundation#3957) * feature(detected_object_validation): add BOUNDING_BOX interface to lanelet filter Signed-off-by: scepter914 <scepter914@gmail.com> * update README Signed-off-by: scepter914 <scepter914@gmail.com> * avoid reuse msg data Signed-off-by: scepter914 <scepter914@gmail.com> --------- Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now, the lanelet filter handle only POLYGON shape type.
So this PR adapt to BOUNDING_BOX shape type.
This change can be used for radar detection.
Tests performed
Tested by rosbag.
Purple objects is input objects and red objects is filtered objects.
Effects on system behavior
This PR doesn't effect to POLYGON type, so doesn't effect to system behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.