Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): drivable area expansion for hatched road markings #3900

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 5, 2023

Description

Fix a minor bug of drivable area expansion considering hatched road markings.

Without this PR
Upper bound is weird in both cases.
image
image

With this PR
image
image

Tests performed

planning simulator

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…markings

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 5, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review June 5, 2023 06:42
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 6.57% and project coverage change: -0.01 ⚠️

Comparison is base (36cad1c) 14.09% compared to head (8f69b62) 14.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3900      +/-   ##
==========================================
- Coverage   14.09%   14.08%   -0.01%     
==========================================
  Files        1446     1446              
  Lines      102069   102110      +41     
  Branches    27228    27251      +23     
==========================================
- Hits        14389    14385       -4     
- Misses      71885    71930      +45     
  Partials    15795    15795              
Flag Coverage Δ *Carryforward flag
differential 13.22% <6.57%> (?)
total 14.09% <ø> (-0.01%) ⬇️ Carriedforward from 36cad1c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._controller/include/mpc_lateral_controller/mpc.hpp 46.66% <ø> (ø)
control/mpc_lateral_controller/src/mpc.cpp 48.29% <ø> (+0.10%) ⬆️
..._lateral_controller/src/mpc_lateral_controller.cpp 33.84% <ø> (-0.90%) ⬇️
control/mpc_lateral_controller/test/test_mpc.cpp 56.60% <ø> (-0.17%) ⬇️
...anner/include/behavior_path_planner/parameters.hpp 50.00% <ø> (ø)
...planner/src/scene_module/lane_change/interface.cpp 14.55% <0.00%> (-0.06%) ⬇️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.24% <0.00%> (-0.36%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 17.54% <15.62%> (+0.19%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit cf1e635 into autowarefoundation:main Jun 5, 2023
@takayuki5168 takayuki5168 deleted the fix/drivable-area-hatched-road-markings branch June 5, 2023 08:29
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 20, 2023
…markings (autowarefoundation#3900)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants