Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): remove lane chagne specific code #3781

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 22, 2023

Description

Remove lane change specific code. This PR make it possible to get crosswalk distance correctry even if there is lane chagne tag.

Tests performed

webauto ci scenario run --project-id prd_jt --scenario-id 1e21c061-5169-4000-b487-23b9abdfc01d --runtime-path /$HOME/pilot-auto --scenario-parameters __tier4_modifier_ego_speed=8.3333
simplescreenrecorder-2023-05-22_14.50.38.mp4

Effects on system behavior

Don't avoid objects around crosswalk.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 22, 2023
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (2cd0bcb) 14.52% compared to head (7469fd4) 14.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3781      +/-   ##
==========================================
+ Coverage   14.52%   14.58%   +0.05%     
==========================================
  Files        1439     1439              
  Lines      101312   103475    +2163     
  Branches    30064    31638    +1574     
==========================================
+ Hits        14711    15087     +376     
- Misses      70513    71952    +1439     
- Partials    16088    16436     +348     
Flag Coverage Δ *Carryforward flag
differential 13.20% <0.00%> (?)
total 14.52% <ø> (+<0.01%) ⬆️ Carriedforward from 2cd0bcb

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/behavior_path_planner/src/utils/utils.cpp 19.87% <0.00%> (+2.99%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4 tkimura4 merged commit c185a7d into autowarefoundation:main May 22, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request May 22, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota deleted the fix/get-crosswalk-distance branch May 22, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants