Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): stabler slow down #3778

Merged
merged 6 commits into from
May 21, 2023

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented May 21, 2023

Description

  • added a lower-pass filter for

    • lateral distance from obstacle to the path
    • slow down start distance
    • slow down velocity
  • calculate slow down velocity from the distance constraints using behavior_velocity_planner's util function.

Tests performed

Effects on system behavior

Stabler slow down planning against close obstacles.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 21, 2023
@takayuki5168 takayuki5168 changed the title Feat/stable slow down2 feat(obstacle_cruise_planner): stabler slow down May 21, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review May 21, 2023 04:45
@takayuki5168 takayuki5168 requested review from purewater0901 and a team as code owners May 21, 2023 04:45
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (2647660) 14.52% compared to head (2c238bc) 14.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3778      +/-   ##
==========================================
- Coverage   14.52%   14.51%   -0.02%     
==========================================
  Files        1442     1442              
  Lines      101489   101583      +94     
  Branches    30167    30204      +37     
==========================================
+ Hits        14745    14746       +1     
- Misses      70604    70692      +88     
- Partials    16140    16145       +5     
Flag Coverage Δ *Carryforward flag
differential 8.80% <0.00%> (?)
total 14.53% <ø> (+<0.01%) ⬆️ Carriedforward from 2647660

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lude/obstacle_cruise_planner/planner_interface.hpp 14.08% <0.00%> (-4.79%) ⬇️
planning/obstacle_cruise_planner/src/node.cpp 13.05% <0.00%> (-0.03%) ⬇️
.../obstacle_cruise_planner/src/planner_interface.cpp 9.02% <0.00%> (-3.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit c16ba06 into autowarefoundation:main May 21, 2023
@takayuki5168 takayuki5168 deleted the feat/stable-slow-down2 branch May 21, 2023 08:25
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request May 21, 2023
…3778)

* feat(obstacle_cruise_planner): stabler slow down

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* use min when inserting slow down

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix slow down appearing twice

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update param

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants