Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(avoidance): remove redundant parameters #3623

Merged
merged 3 commits into from
May 11, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 4, 2023

Description

The lateral_passable_safety_buffer is a param that used for judgement whether ego should avoid, and all objects (car, pedestrian, motorcycle...) used the same value. On the other hand, I already added safety_buffer_lateral for each classes in #3002 and I want to use it instead of lateral_passable_safety_buffer so that we can set the param independently.

NOTE: This PR doesn't depend on the difference between architecuture.

Tests performed

Effects on system behavior

Nothing. (Just refactoring.)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (c41ba06) 13.77% compared to head (8b9b594) 13.79%.

❗ Current head 8b9b594 differs from pull request most recent head f8dd5f8. Consider uploading reports for the commit f8dd5f8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3623      +/-   ##
==========================================
+ Coverage   13.77%   13.79%   +0.02%     
==========================================
  Files        1400     1396       -4     
  Lines       98952    97900    -1052     
  Branches    29348    29071     -277     
==========================================
- Hits        13632    13510     -122     
+ Misses      70511    69794     -717     
+ Partials    14809    14596     -213     
Flag Coverage Δ *Carryforward flag
differential 12.84% <0.00%> (?)
total 13.80% <ø> (+0.02%) ⬆️ Carriedforward from 3744dee

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 19.94% <0.00%> (+0.22%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 3.67% <0.00%> (+0.01%) ⬆️
...ne_module/lane_change/avoidance_by_lane_change.cpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.78% <0.00%> (-0.05%) ⬇️

... and 58 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota force-pushed the refactor/avoidance branch 3 times, most recently from 6b4a368 to 8b9b594 Compare May 8, 2023 05:16
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota merged commit e34253e into autowarefoundation:main May 11, 2023
@satoshi-ota satoshi-ota deleted the refactor/avoidance branch May 11, 2023 01:35
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 17, 2023
…3623)

* refactor(avoidance): rename parameter

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): remove redundant parameter

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(avoidance): update config

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request May 17, 2023
…3623) (#491)

* refactor(avoidance): rename parameter



* fix(avoidance): remove redundant parameter



* refactor(avoidance): update config



---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants