-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(avoidance): remove redundant parameters #3623
refactor(avoidance): remove redundant parameters #3623
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3623 +/- ##
==========================================
+ Coverage 13.77% 13.79% +0.02%
==========================================
Files 1400 1396 -4
Lines 98952 97900 -1052
Branches 29348 29071 -277
==========================================
- Hits 13632 13510 -122
+ Misses 70511 69794 -717
+ Partials 14809 14596 -213
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
6b4a368
to
8b9b594
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
8b9b594
to
f8dd5f8
Compare
…3623) * refactor(avoidance): rename parameter Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): remove redundant parameter Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(avoidance): update config Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
avoidance_execution_lateral_threshold
->lateral_execution_threshold
.lateral_passable_safety_buffer
and use each objects'safety_buffer_lateral
instead.The
lateral_passable_safety_buffer
is a param that used for judgement whether ego should avoid, and all objects (car, pedestrian, motorcycle...) used the same value. On the other hand, I already addedsafety_buffer_lateral
for each classes in #3002 and I want to use it instead oflateral_passable_safety_buffer
so that we can set the param independently.NOTE: This PR doesn't depend on the difference between architecuture.
Tests performed
Effects on system behavior
Nothing. (Just refactoring.)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.