Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): refactoring goal_planner and pull_out params #3610

Merged
merged 1 commit into from
May 4, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented May 2, 2023

Description

refactoring goal_planner and pull_out related params

Related links

autowarefoundation/autoware_launch#338

Tests performed

psim
tier4 internal scenario tets
1328/1350

5/3 daily 1323/1350

Notes for reviewers

Interface changes

nothing

Effects on system behavior

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 8.26% and project coverage change: -0.03 ⚠️

Comparison is base (9524ce7) 13.72% compared to head (3fd346e) 13.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3610      +/-   ##
==========================================
- Coverage   13.72%   13.70%   -0.03%     
==========================================
  Files        1397     1397              
  Lines       98260    98253       -7     
  Branches    29236    29254      +18     
==========================================
- Hits        13491    13468      -23     
- Misses      70232    70234       +2     
- Partials    14537    14551      +14     
Flag Coverage Δ *Carryforward flag
differential 12.16% <8.26%> (?)
total 13.71% <ø> (-0.02%) ⬇️ Carriedforward from 9524ce7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../include/behavior_path_planner/planner_manager.hpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.hpp 75.00% <ø> (ø)
..._planner/scene_module/pull_out/pull_out_module.hpp 66.66% <ø> (ø)
...planner/utils/goal_planner/geometric_pull_over.hpp 0.00% <ø> (ø)
...path_planner/utils/pull_out/geometric_pull_out.hpp 0.00% <ø> (ø)
...ath_planner/utils/pull_out/pull_out_parameters.hpp 0.00% <ø> (ø)
...ehavior_path_planner/src/behavior_tree_manager.cpp 63.63% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 6.20% <ø> (-2.37%) ⬇️
...ic_parallel_parking/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
...ner/src/utils/goal_planner/freespace_pull_over.cpp 11.86% <0.00%> (-0.21%) ⬇️
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…t params

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the refactor/goal_planner_params branch from f4cac4b to 3fd346e Compare May 3, 2023 00:41
@kosuke55 kosuke55 merged commit debd8ca into main May 4, 2023
@kosuke55 kosuke55 deleted the refactor/goal_planner_params branch May 4, 2023 01:55
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…t params (autowarefoundation#3610)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants