Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_planning_rviz_plugin): remove z offset from the bound #3551

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Apr 26, 2023

Description

Remove z offset from the left and right bound to clean the visualization.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (2c3a860) 14.08% compared to head (a2be88a) 14.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3551      +/-   ##
==========================================
+ Coverage   14.08%   14.10%   +0.02%     
==========================================
  Files        1399     1399              
  Lines       97918    97735     -183     
  Branches    29058    28953     -105     
==========================================
  Hits        13788    13788              
+ Misses      69459    69278     -181     
+ Partials    14671    14669       -2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.10% <ø> (+0.02%) ⬆️ Carriedforward from 2c3a860

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ier4_planning_rviz_plugin/include/path/display.hpp 0.00% <ø> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 50.00% <ø> (ø)
.../include/behavior_path_planner/planner_manager.hpp 0.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 34.92% <ø> (ø)
...nner/scene_module/side_shift/side_shift_module.hpp 100.00% <ø> (ø)
...de/behavior_path_planner/utils/avoidance/utils.hpp ∅ <ø> (∅)
...nner/include/behavior_path_planner/utils/utils.hpp 100.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 19.73% <ø> (+0.02%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 3.43% <ø> (+0.01%) ⬆️
...lanner/src/scene_module/avoidance_by_lc/module.cpp 0.00% <ø> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit 3534f6d into main Apr 26, 2023
@purewater0901 purewater0901 deleted the feat/remove-z-offset branch April 26, 2023 14:38
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…owarefoundation#3551)

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants