-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(motion_velocity_smoother): insert the point when applying external velocity limit #3494
fix(motion_velocity_smoother): insert the point when applying external velocity limit #3494
Conversation
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3494 +/- ##
=======================================
Coverage 13.80% 13.81%
=======================================
Files 1391 1391
Lines 97408 97411 +3
Branches 28829 28827 -2
=======================================
+ Hits 13451 13454 +3
- Misses 69501 69502 +1
+ Partials 14456 14455 -1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
planning/motion_velocity_smoother/src/motion_velocity_smoother_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…l velocity limit (autowarefoundation#3494) * fix: insert the point when applying external velocity limit Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * apply velocity limit from the inserted point Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…l velocity limit (#386) fix(motion_velocity_smoother): insert the point when applying external velocity limit (autowarefoundation#3494) * fix: insert the point when applying external velocity limit * apply velocity limit from the inserted point --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…l velocity limit (autowarefoundation#3494) * fix: insert the point when applying external velocity limit Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * apply velocity limit from the inserted point Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
In the current implementation, when applying the external velocity limit, the velocity of the points on the trajectory are being overwritten. However, this implementation has an issue where the inserting position of the external velocity limit is further away than expected and ego vehicle sometimes can't stop at the desired position (see the video below).
In this PR, I have resolved this problem by inserting the point of the external velocity limit.
external_vel_limit_cannot_stop.mp4
Before
After
Tests performed
I confirmed this works with simple planning simulator.
external_vel_limit_psim.mp4
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.