Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_smoother): insert the point when applying external velocity limit #3494

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Apr 21, 2023

Description

In the current implementation, when applying the external velocity limit, the velocity of the points on the trajectory are being overwritten. However, this implementation has an issue where the inserting position of the external velocity limit is further away than expected and ego vehicle sometimes can't stop at the desired position (see the video below).
In this PR, I have resolved this problem by inserting the point of the external velocity limit.

external_vel_limit_cannot_stop.mp4

Before

image

After

image

Tests performed

I confirmed this works with simple planning simulator.

external_vel_limit_psim.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 63.63% and no project coverage change.

Comparison is base (27fa619) 13.80% compared to head (87008dc) 13.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3494   +/-   ##
=======================================
  Coverage   13.80%   13.81%           
=======================================
  Files        1391     1391           
  Lines       97408    97411    +3     
  Branches    28829    28827    -2     
=======================================
+ Hits        13451    13454    +3     
- Misses      69501    69502    +1     
+ Partials    14456    14455    -1     
Flag Coverage Δ *Carryforward flag
differential 6.56% <63.63%> (?)
total 13.80% <ø> (-0.01%) ⬇️ Carriedforward from 7d04f0b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ity_smoother/src/motion_velocity_smoother_node.cpp 23.31% <63.63%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo requested a review from rej55 April 24, 2023 01:28
@TomohitoAndo TomohitoAndo changed the title fix: insert the point when applying external velocity limit fix(motion_velocity_smoother): insert the point when applying external velocity limit Apr 24, 2023
@TomohitoAndo TomohitoAndo merged commit 859513d into autowarefoundation:main Apr 26, 2023
@TomohitoAndo TomohitoAndo deleted the insert-external-velocity-limit-point branch April 26, 2023 09:49
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Apr 26, 2023
…l velocity limit (autowarefoundation#3494)

* fix: insert the point when applying external velocity limit

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* apply velocity limit from the inserted point

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Apr 28, 2023
…l velocity limit (#386)

fix(motion_velocity_smoother): insert the point when applying external velocity limit (autowarefoundation#3494)

* fix: insert the point when applying external velocity limit



* apply velocity limit from the inserted point



---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…l velocity limit (autowarefoundation#3494)

* fix: insert the point when applying external velocity limit

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* apply velocity limit from the inserted point

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants