-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): define DrivableAreaInfo and commonize generateDrivableArea #3444
feat(behavior_path_planner): define DrivableAreaInfo and commonize generateDrivableArea #3444
Conversation
d0810f9
to
e69f5f3
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3444 +/- ##
==========================================
- Coverage 14.97% 14.13% -0.84%
==========================================
Files 1301 1413 +112
Lines 92057 98983 +6926
Branches 29049 29611 +562
==========================================
+ Hits 13788 13994 +206
- Misses 63598 70169 +6571
- Partials 14671 14820 +149
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
44f4944
to
2466b18
Compare
d1cd0f4
to
aef2539
Compare
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
aef2539
to
a247c94
Compare
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
…nerateDrivableArea (autowarefoundation#3444) * feat(behavior_path_planner): generate DrivableArea at last Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix lane change Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix goal planner Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * remove cerr Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/behavior_path_planner/src/planner_manager.cpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
Currently, a drivable area is created in each module.
With a new architecture, since multiple modules can be launched simultaneously, in some cases concatenating drivable area from multiple modules is required, which is difficult to do.
Temporarily the specific implementation for concatenating the drivable area form lane_change, avoidance, and pull_out is used now.
To handle this module-specific temporary implementation, with this PR, the drivable area is created as follows.
I confirmed that the drivable area is generated correctly.
pull out
![image](https://user-images.githubusercontent.com/20228327/234477940-44047a96-4431-432c-8733-6646bbd234ca.png)
lane change
![image](https://user-images.githubusercontent.com/20228327/234477541-57758f7e-7e37-49b6-a7f5-1400ffd740ef.png)
external lane change
![image](https://user-images.githubusercontent.com/20228327/234477460-7897e622-b82a-481d-800c-a018d26f71ac.png)
pull over (not freespace)
![image](https://user-images.githubusercontent.com/20228327/234478413-993eff20-5b3b-4681-9024-a74b2621d4a1.png)
pull over (freespace)
pull out + avoidance
![image](https://user-images.githubusercontent.com/20228327/234478327-515a67c6-bbce-49b5-b041-9392fe0c21d3.png)
Related links
Tests performed
Notes for reviewers
Interface changes
Nothing
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.