Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_adapi_rviz_plugin): add adapi rviz plugin #3380

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Apr 12, 2023

Description

Add rviz plugins for ADAPI. This is temporary implementation for goal mofdification.
I plan to support route options in the future.

Related links

#3370

Tests performed

Check if this tool can be added to rviz.

Notes for reviewers

I plan to merge with tier4_state_rviz_plugin. cc: @h-ohta

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) labels Apr 12, 2023
@isamu-takagi isamu-takagi requested review from h-ohta and kosuke55 April 12, 2023 09:55
@isamu-takagi isamu-takagi self-assigned this Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.80 🎉

Comparison is base (3aead0d) 12.33% compared to head (2ac2911) 13.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3380      +/-   ##
==========================================
+ Coverage   12.33%   13.14%   +0.80%     
==========================================
  Files        1381     1281     -100     
  Lines       96627    90696    -5931     
  Branches    27925    27925              
==========================================
  Hits        11919    11919              
+ Misses      72079    66148    -5931     
  Partials    12629    12629              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 13.14% <ø> (+0.80%) ⬆️ Carriedforward from 50cd593

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/tier4_adapi_rviz_plugin/src/route_tool.cpp 0.00% <0.00%> (ø)

... and 102 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well with
#3370

@kosuke55 kosuke55 merged commit 4095f28 into autowarefoundation:main Apr 13, 2023
@isamu-takagi isamu-takagi deleted the feat/adapi-rviz-plugin branch November 22, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants