feat(route_handler): use pointer for route msgs #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yutaka <purewater0901@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3362 +/- ##
=======================================
Coverage 12.31% 12.31%
=======================================
Files 1381 1380 -1
Lines 96770 96713 -57
Branches 28001 27977 -24
=======================================
- Hits 11916 11910 -6
+ Misses 72223 72174 -49
+ Partials 12631 12629 -2
*This pull request uses carry forward flags. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
kosuke55
approved these changes
Apr 11, 2023
Signed-off-by: yutaka <purewater0901@gmail.com>
rej55
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a pointer for route msgs to protect from invalid data access when it route handler does not have a valid route.
🤖 Generated by Copilot at 99532f5
Refactored the
RouteHandlerclass to use a shared pointer for the route message, improving memory efficiency and enabling message sharing. Added null checks and default values for route information functions.Tests performed
PSim
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.