Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_centerline_optimizer): add mission_planner's param for launch #3360

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 11, 2023

Description

static_centerline_optimizer cannot be launched from autoware_launch due to the following change.
#3127

I added mission_planner's param when launching static_centerline_optimizer from launch.

FYI: The test to launch static_centerline_optimizer (not from autoware_launch) passed since mission_planner's parameter is given in this case.

os.path.join(
get_package_share_directory("mission_planner"),
"config",
"mission_planner.param.yaml",
),

Tests performed

launch test passed.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 11, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review April 11, 2023 17:22
@takayuki5168 takayuki5168 requested review from kosuke55 and a team as code owners April 11, 2023 17:22
@takayuki5168
Copy link
Contributor Author

@kosuke55 Could you approve the PR.

@takayuki5168 takayuki5168 requested a review from shmpwk April 11, 2023 17:28
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (61d886f) 12.32% compared to head (7d87c7f) 12.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3360   +/-   ##
=======================================
  Coverage   12.32%   12.32%           
=======================================
  Files        1380     1380           
  Lines       96704    96704           
  Branches    27971    27971           
=======================================
  Hits        11918    11918           
  Misses      72156    72156           
  Partials    12630    12630           
Flag Coverage Δ *Carryforward flag
differential 29.47% <ø> (?)
total 12.32% <ø> (ø) Carriedforward from 61d886f

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shmpwk shmpwk merged commit d24a2be into autowarefoundation:main Apr 12, 2023
@shmpwk shmpwk deleted the fix/static-centerline-optimizer-mission-planner-param branch April 12, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants