refactor(avoidance): remove duplicated utils function

[satoshi-ota]

Description

avoidance and avoidance_by_lc module have several same functions.

autoware.universe/planning/behavior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_module.hpp

Lines 180 to 185 in 5b6b5ad

	void fillObjectEnvelopePolygon(const Pose & closest_pose, ObjectData & object_data) const;
	void fillObjectMovingTime(ObjectData & object_data) const;
	void compensateDetectionLost(
	ObjectDataArray & target_objects, ObjectDataArray & other_objects) const;

autoware.universe/planning/behavior_path_planner/include/behavior_path_planner/scene_module/avoidance_by_lc/module.hpp

Lines 173 to 179 in 5b6b5ad

	void fillAvoidanceTargetObjects(AvoidancePlanningData & data, DebugData & debug) const;
	void fillObjectEnvelopePolygon(const Pose & closest_pose, ObjectData & object_data) const;
	void fillObjectMovingTime(ObjectData & object_data) const;
	void updateRegisteredObject(const ObjectDataArray & objects);
	void compensateDetectionLost(
	ObjectDataArray & target_objects, ObjectDataArray & other_objects) const;
	bool isTargetObjectType(const PredictedObject & object) const;

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (61d886f) 13.12% compared to head (41f1559) 13.07%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3350      +/-   ##
==========================================
- Coverage   13.12%   13.07%   -0.06%     
==========================================
  Files        1279     1279              
  Lines       90765    91161     +396     
  Branches    27971    28268     +297     
==========================================
+ Hits        11916    11917       +1     
- Misses      66218    66537     +319     
- Partials    12631    12707      +76     

Flag	Coverage Δ		*Carryforward flag
differential	5.34% <0.00%> (?)
total	13.19% <ø> (+0.06%)	⬆️	Carriedforward from 61d886f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp	0.00% <ø> (ø)
...th_planner/scene_module/avoidance_by_lc/module.hpp	0.00% <ø> (ø)
...h_planner/util/avoidance/avoidance_module_data.hpp	0.00% <ø> (ø)
...lude/behavior_path_planner/util/avoidance/util.hpp	0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp	0.00% <0.00%> (ø)
...lanner/src/scene_module/avoidance_by_lc/module.cpp	0.00% <0.00%> (ø)
.../behavior_path_planner/src/util/avoidance/util.cpp	0.78% <0.00%> (-0.55%)	⬇️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[purewater0901]

LGTM