Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(perception): workaround for nvcc > 11.6 #3310

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Apr 7, 2023

Description

Fix the compile error namespace cuda::std ... for .cu files

Tests performed

The source files can be still compiled using nvcc == 11.6 on my local machine too.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Apr 7, 2023
@soblin soblin marked this pull request as ready for review April 7, 2023 10:09
@soblin soblin requested review from wep21, a team, knzo25 and yukke42 as code owners April 7, 2023 10:09
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (df450d1) 12.36% compared to head (3b2dc42) 12.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3310   +/-   ##
=======================================
  Coverage   12.36%   12.37%           
=======================================
  Files        1368     1368           
  Lines       96006    95953   -53     
  Branches    27555    27537   -18     
=======================================
+ Hits        11874    11876    +2     
+ Misses      71592    71538   -54     
+ Partials    12540    12539    -1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 12.37% <ø> (+<0.01%) ⬆️ Carriedforward from d582c30

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nterpoint/include/lidar_centerpoint/cuda_utils.hpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/cuda_utils.hpp 0.00% <0.00%> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 83.33% <ø> (ø)
...lanner/src/scene_module/avoidance_by_lc/module.cpp 0.00% <ø> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <ø> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <ø> (ø)
planning/behavior_path_planner/src/utilities.cpp 8.50% <ø> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green ci.

Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin merged commit 4ab676a into autowarefoundation:main Apr 7, 2023
@soblin soblin deleted the fix/nvcc12 branch April 7, 2023 11:30
soblin added a commit to soblin/autoware.universe that referenced this pull request May 15, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 26, 2024
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants