Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): move modified goal callback for reroute #3297

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Apr 6, 2023

Description

Move callback to allow reroute when modified_route is received.
autowarefoundation/autoware#3406

Tests performed

Check /api/routing/state will be ARRIVED when the goal is changed by pull over.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Apr 6, 2023
@isamu-takagi isamu-takagi requested a review from yukkysaito April 6, 2023 11:25
@isamu-takagi isamu-takagi self-assigned this Apr 6, 2023
@isamu-takagi isamu-takagi removed their assignment Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (cfecdf8) 12.37% compared to head (a6d2f60) 12.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3297      +/-   ##
==========================================
- Coverage   12.37%   12.37%   -0.01%     
==========================================
  Files        1368     1368              
  Lines       96003    96004       +1     
  Branches    27552    27552              
==========================================
  Hits        11877    11877              
- Misses      71588    71589       +1     
  Partials    12538    12538              
Flag Coverage Δ *Carryforward flag
differential 21.14% <0.00%> (?)
total 12.37% <ø> (+<0.01%) ⬆️ Carriedforward from cfecdf8

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...on_planner/src/mission_planner/arrival_checker.cpp 0.00% <ø> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit b33d4bb into autowarefoundation:main Apr 10, 2023
@isamu-takagi isamu-takagi deleted the feat/mission-planner-reroute-modified-goal branch April 10, 2023 06:01
@isamu-takagi isamu-takagi self-assigned this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants