Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): use perception utils for interpolation #3255

Merged
merged 6 commits into from
Apr 4, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Apr 3, 2023

Description

Using perception utils for functions in utilities of the behavior path planner

Related links

Tests performed

Tier4 Scenario Test 1198/1199
Internal Link

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.83 ⚠️

Comparison is base (37f67f5) 13.21% compared to head (2197a99) 12.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3255      +/-   ##
==========================================
- Coverage   13.21%   12.39%   -0.83%     
==========================================
  Files        1263     1363     +100     
  Lines       89337    95139    +5802     
  Branches    27079    26993      -86     
==========================================
- Hits        11809    11793      -16     
- Misses      65104    70989    +5885     
+ Partials    12424    12357      -67     
Flag Coverage Δ *Carryforward flag
differential 5.54% <0.00%> (?)
total 12.40% <ø> (-0.82%) ⬇️ Carriedforward from e5cb317

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/include/behavior_path_planner/utilities.hpp 83.33% <ø> (+59.52%) ⬆️
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 7.85% <0.00%> (+0.28%) ⬆️

... and 105 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Apr 4, 2023
@kosuke55 kosuke55 changed the title feat(behavior_path_planner): use perception utils for interpolation refactor(behavior_path_planner): use perception utils for interpolation Apr 4, 2023
@purewater0901 purewater0901 merged commit 8851f23 into main Apr 4, 2023
@purewater0901 purewater0901 deleted the feat/use-perception-utils-for-interpolation branch April 4, 2023 02:48
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants