Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mission_planner): add route loop check #3250

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Apr 3, 2023

Description

Add route loop check to getLaneletSequenceAfter and getLaneletSequenceUpTo for solving endless while loop when the route is a loop.

ex)
if the route is following, getLaneletSequence(current_lane) can't end.

Screenshot from 2023-04-03 16-47-02
Screenshot from 2023-04-03 16-40-22

[component_container_mt-27] current_lanelet: 174, next_lanelet: 190162
[component_container_mt-27] current_lanelet: 190162, next_lanelet: 143
[component_container_mt-27] current_lanelet: 143, next_lanelet: 146
[component_container_mt-27] current_lanelet: 146, next_lanelet: 1003
[component_container_mt-27] current_lanelet: 1003, next_lanelet: 1506
[component_container_mt-27] current_lanelet: 1506, next_lanelet: 176321
[component_container_mt-27] current_lanelet: 176321, next_lanelet: 1520
[component_container_mt-27] current_lanelet: 1520, next_lanelet: 1509
[component_container_mt-27] current_lanelet: 1509, next_lanelet: 1368
[component_container_mt-27] current_lanelet: 1368, next_lanelet: 1489
[component_container_mt-27] current_lanelet: 1489, next_lanelet: 1492
[component_container_mt-27] current_lanelet: 1492, next_lanelet: 1495
[component_container_mt-27] current_lanelet: 1495, next_lanelet: 1176
[component_container_mt-27] current_lanelet: 1176, next_lanelet: 126
[component_container_mt-27] current_lanelet: 126, next_lanelet: 785
[component_container_mt-27] current_lanelet: 785, next_lanelet: 132
[component_container_mt-27] current_lanelet: 132, next_lanelet: 134
[component_container_mt-27] current_lanelet: 134, next_lanelet: 783
[component_container_mt-27] current_lanelet: 783, next_lanelet: 139
[component_container_mt-27] current_lanelet: 139, next_lanelet: 141
[component_container_mt-27] current_lanelet: 141, next_lanelet: 1133
[component_container_mt-27] current_lanelet: 1133, next_lanelet: 70
[component_container_mt-27] current_lanelet: 70, next_lanelet: 72
[component_container_mt-27] current_lanelet: 72, next_lanelet: 1145
[component_container_mt-27] current_lanelet: 1145, next_lanelet: 170
[component_container_mt-27] current_lanelet: 170, next_lanelet: 172
[component_container_mt-27] current_lanelet: 172, next_lanelet: 174

Related links

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 3, 2023
@kosuke55 kosuke55 requested a review from takayuki5168 April 3, 2023 08:21
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.23 ⚠️

Comparison is base (5d4727e) 12.25% compared to head (0dc64db) 12.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3250      +/-   ##
==========================================
- Coverage   12.25%   12.02%   -0.23%     
==========================================
  Files        1358     1358              
  Lines       94746    98051    +3305     
  Branches    26915    29206    +2291     
==========================================
+ Hits        11608    11790     +182     
- Misses      70874    73720    +2846     
- Partials    12264    12541     +277     
Flag Coverage Δ *Carryforward flag
differential 5.26% <50.00%> (?)
total 12.25% <ø> (ø) Carriedforward from 5d4727e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/route_handler/src/route_handler.cpp 13.40% <50.00%> (+2.13%) ⬆️

... and 25 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 50916f9 into autowarefoundation:main Apr 4, 2023
@kosuke55 kosuke55 deleted the fix/route_loop branch April 4, 2023 09:21
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants