Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): clean the code of common drivable area generation #3246

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 3, 2023

Description

clean the code of common drivable area generation

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ea generation

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 3, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

@satoshi-ota Could you review the PR.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (70cf872) 12.33% compared to head (dc4375b) 12.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3246   +/-   ##
=======================================
  Coverage   12.33%   12.33%           
=======================================
  Files        1363     1363           
  Lines       94810    94810           
  Branches    27000    27000           
=======================================
  Hits        11697    11697           
  Misses      70763    70763           
  Partials    12350    12350           
Flag Coverage Δ *Carryforward flag
differential 5.48% <0.00%> (?)
total 12.34% <ø> (+<0.01%) ⬆️ Carriedforward from 70cf872

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit ff96800 into autowarefoundation:main Apr 4, 2023
@takayuki5168 takayuki5168 deleted the refactor/behavior-path-common-drivable-lane branch April 4, 2023 04:42
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…ea generation (autowarefoundation#3246)

* refactor(behavior_path_planner): clean the code of common drivable area generation

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants