Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): fix invalid access #3187

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 28, 2023

Description

Without this PR, the behavior_velocity_planner dies due to invalid access in the intersection module.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review March 28, 2023 08:09
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 28, 2023
@soblin
Copy link
Contributor

soblin commented Mar 28, 2023

@takayuki5168 Thank you. I guess I mistakenly cherry-picked from my feature branch and made that commit.

@takayuki5168 takayuki5168 enabled auto-merge (squash) March 28, 2023 08:14
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (1ef312b) 12.27% compared to head (d9b2ffb) 12.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3187      +/-   ##
==========================================
- Coverage   12.27%   12.26%   -0.01%     
==========================================
  Files        1358     1358              
  Lines       94666    94675       +9     
  Branches    26858    26865       +7     
==========================================
  Hits        11616    11616              
- Misses      70804    70812       +8     
- Partials    12246    12247       +1     
Flag Coverage Δ *Carryforward flag
differential 3.91% <0.00%> (?)
total 12.27% <ø> (ø) Carriedforward from 1ef312b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 1ed2648 into autowarefoundation:main Mar 28, 2023
@takayuki5168 takayuki5168 deleted the fix/intersection-die branch March 28, 2023 09:16
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Mar 29, 2023
…n#3187)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
swiftfile pushed a commit to swiftfile/autoware.universe that referenced this pull request Mar 29, 2023
…n#3187)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Yusuke Mizoguchi <sky.y.m.318@gmail.com>
swiftfile pushed a commit to swiftfile/autoware.universe that referenced this pull request Mar 29, 2023
…n#3187)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Yusuke Mizoguchi <sky.y.m.318@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…n#3187)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants