Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mpc): remove old library dependency #3165

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Mar 27, 2023

Description

remove old autoware_auto dependency

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested review from takayuki5168 and a team as code owners March 27, 2023 02:44
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Mar 27, 2023
@TakaHoribe TakaHoribe changed the title refactor(mpc): remove old library refactor(mpc): remove old library dependency Mar 27, 2023
@TakaHoribe TakaHoribe enabled auto-merge (squash) March 27, 2023 02:54
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.01 ⚠️

Comparison is base (319577a) 12.31% compared to head (d81bf4e) 12.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3165      +/-   ##
==========================================
- Coverage   12.31%   12.31%   -0.01%     
==========================================
  Files        1340     1340              
  Lines       93513    93512       -1     
  Branches    26777    26776       -1     
==========================================
- Hits        11519    11518       -1     
- Misses      69832    69835       +3     
+ Partials    12162    12159       -3     
Flag Coverage Δ *Carryforward flag
differential 46.49% <33.33%> (?)
total 12.31% <ø> (-0.01%) ⬇️ Carriedforward from 319577a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._controller/include/mpc_lateral_controller/mpc.hpp 46.66% <ø> (ø)
control/mpc_lateral_controller/src/mpc.cpp 48.44% <ø> (ø)
control/mpc_lateral_controller/src/mpc_utils.cpp 56.80% <33.33%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe merged commit b38eae6 into autowarefoundation:main Mar 27, 2023
@TakaHoribe TakaHoribe deleted the refac/mpc-remove-old-dependency branch March 27, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants