Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lidar_centerpoint): add a check between the model and config's class size #3101

Merged
merged 13 commits into from
Mar 28, 2023
Merged

chore(lidar_centerpoint): add a check between the model and config's class size #3101

merged 13 commits into from
Mar 28, 2023

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Mar 17, 2023

Description

add a check between the model and config's class size

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@knzo25
Add a check for the class size between the model and the config
d7d05ba 
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 requested review from yukke42 and a team as code owners March 17, 2023 02:40
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.76 ⚠️

Comparison is base (1ed2648) 13.07% compared to head (2a7d17b) 12.32%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3101      +/-   ##
==========================================
- Coverage   13.07%   12.32%   -0.76%     
==========================================
  Files        1257     1355      +98     
  Lines       88806    94268    +5462     
  Branches    26865    26819      -46     
==========================================
+ Hits        11614    11616       +2     
- Misses      64945    70406    +5461     
+ Partials    12247    12246       -1
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 12.32% <ø> (-0.76%) ⬇️ Carriedforward from a883990

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._loader/test/test_pointcloud_map_loader_module.cpp 45.45% <ø> (ø)
...tion/lidar_centerpoint/lib/network/network_trt.cpp 0.00% <ø> (ø)
...lidar_centerpoint/lib/network/tensorrt_wrapper.cpp 0.00% <ø> (ø)

... and 110 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knzo25
Changed std::cout for logger calls
f0f0d38 
Fixed typos

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 requested review from wep21 and manato as code owners March 17, 2023 05:53
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Mar 17, 2023
yukke42
yukke42 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It works fine!

@knzo25
Copy link
Contributor Author

knzo25 commented Mar 17, 2023

?
Do we need the approval from all the reviewers?

@yukke42
Copy link
Contributor

yukke42 commented Mar 17, 2023

Either @wep21 or @manato. They are code owners of the tensorrt_common package.

@knzo25
Copy link
Contributor Author

knzo25 commented Mar 17, 2023

Ooh right, thanks !

knzo25 added 2 commits March 28, 2023 01:28
@knzo25
Changed to the standard rclcpp logger
433168e 
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25
Deleted unused logic
c686a83 
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Mar 27, 2023
@knzo25
Copy link
Contributor Author

knzo25 commented Mar 27, 2023

@yukke42
Sorry for the delay. I applied the changes

yukke42
yukke42 suggested changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check a change suggestion.

@knzo25 @yukke42
Update perception/lidar_centerpoint/lib/network/tensorrt_wrapper.cpp
2a6b241 
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
@knzo25
Copy link
Contributor Author

knzo25 commented Mar 28, 2023

pls check a change suggestion.

🙇

yukke42
yukke42 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knzo25 knzo25 enabled auto-merge (squash) March 28, 2023 11:46
@knzo25 knzo25 merged commit 763d1a2 into autowarefoundation:main Mar 28, 2023
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Mar 29, 2023
Merged
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
@knzo25 @yukke42 @ktro2828
chore(lidar_centerpoint): add a check between the model and config's …
90ce4b4 
…class size (autowarefoundation#3101)

* Add a check for the class size between the model and the config

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Changed std::cout for logger calls
Fixed typos

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Missed some couts

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Changed to the standard rclcpp logger

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Deleted unused logic

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/lidar_centerpoint/lib/network/tensorrt_wrapper.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wep21 wep21 wep21 left review comments

@yukke42 yukke42 yukke42 approved these changes

@manato manato Awaiting requested review from manato

Assignees
No one assigned
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knzo25 @yukke42 @wep21