Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run_out): place of clearing points #3021

Merged

Conversation

TomohitoAndo
Copy link
Contributor

Description

Detected points are sometimes unintentionally deleted because the place of obstacle_points_map_filtered_.clear() was inappropriate.

I confirmed this works with Planning Simulator.
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2a43c7) 11.94% compared to head (956219d) 11.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3021   +/-   ##
=======================================
  Coverage   11.94%   11.94%           
=======================================
  Files        1321     1321           
  Lines       91907    91907           
  Branches    24502    24503    +1     
=======================================
  Hits        10976    10976           
  Misses      69573    69573           
  Partials    11358    11358           
Flag Coverage Δ *Carryforward flag
differential 3.91% <0.00%> (?)
total 11.94% <ø> (+<0.01%) ⬆️ Carriedforward from b2a43c7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/src/scene_module/run_out/dynamic_obstacle.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkuri
Copy link
Contributor

mkuri commented Mar 8, 2023

Memo

  • If the input point cloud is not empty and the point cloud is being processed, the previous point cloud is used for the planning callback.
  • If the input point cloud is empty, it is cleared and the function exits to reduce processing.

Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit ee60ab2 into autowarefoundation:main Mar 8, 2023
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2023
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2023
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants