Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): use lane following params in new framework #3001

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 5, 2023

Description

Sinse the lane following planning logic is built in planner manager on the new framework, the lane following module is no longer needed to launch. In this PR, it is able to use same lane following parameters in planner manager.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 5, 2023
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (806db52) 11.92% compared to head (ed39356) 11.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3001   +/-   ##
=======================================
  Coverage   11.92%   11.92%           
=======================================
  Files        1318     1319    +1     
  Lines       91815    91813    -2     
  Branches    24461    24460    -1     
=======================================
  Hits        10953    10953           
+ Misses      69503    69500    -3     
- Partials    11359    11360    +1     
Flag Coverage Δ *Carryforward flag
differential 5.62% <0.00%> (?)
total 11.93% <ø> (+<0.01%) ⬆️ Carriedforward from 806db52

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...ne_module/lane_following/lane_following_module.hpp 0.00% <ø> (ø)
...r_path_planner/util/lane_following/module_data.hpp 0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.14% <0.00%> (ø)
...ne_module/lane_following/lane_following_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 8814cca into autowarefoundation:main Mar 7, 2023
@satoshi-ota satoshi-ota deleted the fix/use-lane-following-param branch March 7, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants