Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointcloud_preprocessor): throw error if crop box input frame is missing #2980

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

VRichardJP
Copy link
Contributor

Description

See #2974 (comment)

For example, crop box filters in euclidian cluster container would crash early before #2979 fix:

[ERROR 1677724830.546998321] [perception.object_recognition.detection.clustering.euclidean_cluster_container]: Component constructor threw an exception: Crop box requires non-empty input_frame (on_load_node() at ./src/component_manager.cpp:278)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@VRichardJP VRichardJP requested review from amc-nu, miursh, yukkysaito and a team as code owners March 2, 2023 02:45
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Mar 2, 2023
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VRichardJP VRichardJP force-pushed the patch-4 branch 3 times, most recently from 939869b to 77644a0 Compare March 3, 2023 06:34
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (8b8a37e) 11.92% compared to head (46ef392) 11.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2980      +/-   ##
==========================================
- Coverage   11.92%   11.92%   -0.01%     
==========================================
  Files        1318     1318              
  Lines       91815    91817       +2     
  Branches    24461    24461              
==========================================
  Hits        10953    10953              
- Misses      69503    69505       +2     
  Partials    11359    11359              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.92% <ø> (ø) Carriedforward from 8b8a37e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or/src/crop_box_filter/crop_box_filter_nodelet.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…missing

Signed-off-by: Vincent Richard <vincent.francois.richard@gmail.com>
@miursh miursh merged commit 3a6f487 into autowarefoundation:main Mar 6, 2023
@VRichardJP VRichardJP deleted the patch-4 branch March 22, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants