Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_stop_planner): add margin behind goal #2953

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Feb 27, 2023

Description

Add margin for the obstacle behind the goal.

obstacle_stop_margin_behind_goal-2023-02-27_18.29.57.mp4

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 11.52% // Head: 11.52% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (0007f76) compared to base (b28d792).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2953      +/-   ##
==========================================
- Coverage   11.52%   11.52%   -0.01%     
==========================================
  Files        1314     1314              
  Lines       92794    92799       +5     
  Branches    24997    24997              
==========================================
  Hits        10699    10699              
- Misses      70853    70858       +5     
  Partials    11242    11242              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.52% <ø> (+<0.01%) ⬆️ Carriedforward from bdbd3f2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_stop_planner/src/node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 merged commit 640cb61 into autowarefoundation:main Feb 27, 2023
@kosuke55 kosuke55 deleted the feat/obstacle_stop_margin_behind_goal branch February 27, 2023 22:31
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
…on#2953)

* feat(obstacle_stop_planner): add margin behind goal

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* refactor: just compare end index

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…on#2953)

* feat(obstacle_stop_planner): add margin behind goal

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* refactor: just compare end index

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants