Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_state_panel): change variable for fail safe behavior #2952

Conversation

yabuta
Copy link
Contributor

@yabuta yabuta commented Feb 27, 2023

Description

The reference variable for fail safe behavior was incorrect and has been corrected.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 27, 2023
@yabuta yabuta changed the title fix(autoware_state_panel): Change fail safe behavior value fix(autoware_state_panel): change variable for fail safe behavior Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 12.30% // Head: 12.30% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bb4a6eb) compared to base (a7ff179).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2952   +/-   ##
=======================================
  Coverage   12.30%   12.30%           
=======================================
  Files        1212     1212           
  Lines       86927    86920    -7     
  Branches    24996    24995    -1     
=======================================
  Hits        10697    10697           
+ Misses      64987    64980    -7     
  Partials    11243    11243           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 12.30% <ø> (+<0.01%) ⬆️ Carriedforward from a7ff179

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% <0.00%> (ø)
...analysis/src/control_performance_analysis_node.cpp 0.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.15% <ø> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yabuta yabuta marked this pull request as ready for review February 27, 2023 03:03
@yabuta yabuta requested review from h-ohta, isamu-takagi and a team as code owners February 27, 2023 03:03
@yabuta yabuta merged commit fb15433 into autowarefoundation:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants