-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(motion_velocity_smoother): delete default values #2935
refactor(motion_velocity_smoother): delete default values #2935
Conversation
Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
I'll review this PR. |
Codecov ReportBase: 11.79% // Head: 11.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
==========================================
- Coverage 11.79% 11.74% -0.06%
==========================================
Files 1322 1322
Lines 92793 93404 +611
Branches 24997 25451 +454
==========================================
+ Hits 10945 10968 +23
- Misses 70375 70901 +526
- Partials 11473 11535 +62
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I checked it causes no error in all algorithm (L2, JerkFiltered, Linf, Analytical). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…undation#2935) * delete param Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp> Co-authored-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…undation#2935) * delete param Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp> Co-authored-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Removed default values defined in declare_parameter function.
motion_velocity_smoother_delete_param.webm
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.