Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(motion_velocity_smoother): delete default values #2935

Conversation

yamazakiTasuku
Copy link
Contributor

@yamazakiTasuku yamazakiTasuku commented Feb 22, 2023

Description

Removed default values defined in declare_parameter function.
motion_velocity_smoother_delete_param.webm

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
@yamazakiTasuku yamazakiTasuku requested review from rej55 and a team as code owners February 22, 2023 09:30
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 22, 2023
@satoshi-ota satoshi-ota changed the title fix(motion_velocity_smoother_delete_param):delete default values fix(motion_velocity_smoother): delete default values Feb 24, 2023
@satoshi-ota
Copy link
Contributor

I'll review this PR.

@satoshi-ota satoshi-ota self-requested a review February 24, 2023 01:33
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 11.79% // Head: 11.74% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (4d0242e) compared to base (e161141).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2935      +/-   ##
==========================================
- Coverage   11.79%   11.74%   -0.06%     
==========================================
  Files        1322     1322              
  Lines       92793    93404     +611     
  Branches    24997    25451     +454     
==========================================
+ Hits        10945    10968      +23     
- Misses      70375    70901     +526     
- Partials    11473    11535      +62     
Flag Coverage Δ *Carryforward flag
differential 3.34% <0.00%> (?)
total 11.80% <ø> (+<0.01%) ⬆️ Carriedforward from e161141

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ity_smoother/src/motion_velocity_smoother_node.cpp 0.00% <0.00%> (ø)
..._smoother/analytical_jerk_constrained_smoother.cpp 0.00% <0.00%> (ø)
...y_smoother/src/smoother/jerk_filtered_smoother.cpp 0.00% <0.00%> (ø)
..._smoother/src/smoother/l2_pseudo_jerk_smoother.cpp 0.00% <0.00%> (ø)
...moother/src/smoother/linf_pseudo_jerk_smoother.cpp 0.00% <0.00%> (ø)
...n_velocity_smoother/src/smoother/smoother_base.cpp 0.00% <0.00%> (ø)
...vior_velocity_planner/include/utilization/util.hpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota changed the title fix(motion_velocity_smoother): delete default values refactor(motion_velocity_smoother): delete default values Feb 27, 2023
@satoshi-ota
Copy link
Contributor

I checked it causes no error in all algorithm (L2, JerkFiltered, Linf, Analytical).

@satoshi-ota satoshi-ota enabled auto-merge (squash) February 27, 2023 04:47
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit b28d792 into autowarefoundation:main Feb 27, 2023
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
…undation#2935)

* delete param

Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Co-authored-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…undation#2935)

* delete param

Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Co-authored-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants