-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(intersection): improve generate stopline functions #2918
refactor(intersection): improve generate stopline functions #2918
Conversation
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Codecov ReportBase: 11.79% // Head: 11.78% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2918 +/- ##
==========================================
- Coverage 11.79% 11.78% -0.01%
==========================================
Files 1322 1322
Lines 92816 92829 +13
Branches 25011 25019 +8
==========================================
Hits 10944 10944
- Misses 70398 70410 +12
- Partials 11474 11475 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@takayuki5168 can you approve this refactoring (+ a minor performance update) ? |
Description
Refactored improved the performance of
getFirstPointInsidePolygons()
,gererateStuckStopLine()
,generateStopLine()
by caching the polygons that the path intersects first from 1ms to 0.1ms.Tests performed
CI: https://evaluation.tier4.jp/evaluation/reports/8708fada-ed90-5b81-b6f7-cc4e4ea4e5ac?project_id=prd_jt
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.