Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(intersection): improve generate stopline functions #2918

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 20, 2023

Description

Refactored improved the performance of getFirstPointInsidePolygons(), gererateStuckStopLine(), generateStopLine() by caching the polygons that the path intersects first from 1ms to 0.1ms.

Tests performed

CI: https://evaluation.tier4.jp/evaluation/reports/8708fada-ed90-5b81-b6f7-cc4e4ea4e5ac?project_id=prd_jt

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 11.79% // Head: 11.78% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4d3ca76) compared to base (3f07107).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2918      +/-   ##
==========================================
- Coverage   11.79%   11.78%   -0.01%     
==========================================
  Files        1322     1322              
  Lines       92816    92829      +13     
  Branches    25011    25019       +8     
==========================================
  Hits        10944    10944              
- Misses      70398    70410      +12     
- Partials    11474    11475       +1     
Flag Coverage Δ *Carryforward flag
differential 3.91% <0.00%> (?)
total 11.79% <ø> (+<0.01%) ⬆️ Carriedforward from 3f07107

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
...ule/intersection/scene_merge_from_private_road.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin marked this pull request as ready for review February 21, 2023 01:10
@soblin soblin changed the title perf(intersection): improve generate stopline functions refactor(intersection): improve generate stopline functions Feb 21, 2023
@soblin
Copy link
Contributor Author

soblin commented Feb 21, 2023

@takayuki5168 can you approve this refactoring (+ a minor performance update) ?

@soblin soblin merged commit f070349 into autowarefoundation:main Feb 21, 2023
@soblin soblin deleted the perf/improve-generate-stopline-functions branch February 21, 2023 07:20
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants