-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): fix cutOverlappedLanes #2916
fix(behavior_path_planner): fix cutOverlappedLanes #2916
Conversation
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Codecov ReportBase: 11.79% // Head: 11.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2916 +/- ##
==========================================
- Coverage 11.79% 11.79% -0.01%
==========================================
Files 1322 1322
Lines 92804 92811 +7
Branches 25004 25009 +5
==========================================
Hits 10944 10944
- Misses 70386 70393 +7
Partials 11474 11474
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n#2916) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#2916) (#286) * fix(behavior_path_planner): fix pull over deceleration before search area start (autowarefoundation#2898) (#283) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix(behavior_path_planner): fix cutOverlappedLanes (autowarefoundation#2916) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#2916) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#2916) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#2916) (#286) * fix(behavior_path_planner): fix pull over deceleration before search area start (autowarefoundation#2898) (#283) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix(behavior_path_planner): fix cutOverlappedLanes (autowarefoundation#2916) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#2916) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
In the cause of the video, lanes and the path are cut with
cutOverlappedLanes
and the vehicle gets stuck.The cause of this is that when a lane intersects at even a single point, that lane and path point are removed.
In this PR, lanes with a single point of intersection are kept.
drivable_area_overlap-2023-02-20_12.36.56.mp4
NOTES:
After discussion with @purewater0901 @TakaHoribe, it is better to keep lanes that share a linestring too and remove only lanes that completely overlap, but the former requires modifying
generateDrivableArea
, so it is left removed in this PR.todo: support
generateDrivableArea
for lanes sharing a linestringRelated links
Tests performed
psim
tier iv internal scenario test 811/814 ok
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.