Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix cutOverlappedLanes #2916

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Feb 20, 2023

Description

In the cause of the video, lanes and the path are cut with cutOverlappedLanes and the vehicle gets stuck.
The cause of this is that when a lane intersects at even a single point, that lane and path point are removed.
In this PR, lanes with a single point of intersection are kept.

drivable_area_overlap-2023-02-20_12.36.56.mp4

NOTES:

After discussion with @purewater0901 @TakaHoribe, it is better to keep lanes that share a linestring too and remove only lanes that completely overlap, but the former requires modifying generateDrivableArea, so it is left removed in this PR.

todo: support generateDrivableArea for lanes sharing a linestring

Related links

Tests performed

psim
tier iv internal scenario test 811/814 ok

Screenshot from 2023-02-20 17-10-04
Screenshot from 2023-02-20 17-10-12

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 11.79% // Head: 11.79% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (bfbce8c) compared to base (ce82f3d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2916      +/-   ##
==========================================
- Coverage   11.79%   11.79%   -0.01%     
==========================================
  Files        1322     1322              
  Lines       92804    92811       +7     
  Branches    25004    25009       +5     
==========================================
  Hits        10944    10944              
- Misses      70386    70393       +7     
  Partials    11474    11474              
Flag Coverage Δ *Carryforward flag
differential 6.16% <0.00%> (?)
total 11.79% <ø> (+<0.01%) ⬆️ Carriedforward from ce82f3d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/behavior_path_planner/src/utilities.cpp 8.36% <0.00%> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit e50dc49 into autowarefoundation:main Feb 21, 2023
@kosuke55 kosuke55 deleted the fix/cut_overlapped_lanes branch February 21, 2023 07:28
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Feb 27, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Feb 27, 2023
…n#2916) (#286)

* fix(behavior_path_planner): fix pull over deceleration before search area start (autowarefoundation#2898) (#283)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix(behavior_path_planner): fix cutOverlappedLanes (autowarefoundation#2916)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
taikitanaka3 pushed a commit to tier4/autoware.universe that referenced this pull request Mar 6, 2023
…n#2916) (#286)

* fix(behavior_path_planner): fix pull over deceleration before search area start (autowarefoundation#2898) (#283)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix(behavior_path_planner): fix cutOverlappedLanes (autowarefoundation#2916)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants