Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): drivable area with static obstacles #2880

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 13, 2023

Description

This includes the change of #2852

dealt with complicated static obstacles

rough sketch of the algorithm on this PR.
image

case1
before
image
after
image

case2
before
image
after
image

case3
before
image
after
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 13, 2023
@takayuki5168 takayuki5168 changed the title Fix/drivable area with static obstacles fix(behavior_path_planner): drivable area with static obstacles Feb 13, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review February 14, 2023 17:01
@takayuki5168 takayuki5168 force-pushed the fix/drivable-area-with-static-obstacles branch 2 times, most recently from 6b1a655 to eb677ea Compare February 16, 2023 17:23
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 11.77% // Head: 11.75% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (732a8d7) compared to base (46e6315).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
- Coverage   11.77%   11.75%   -0.02%     
==========================================
  Files        1324     1325       +1     
  Lines       92960    93058      +98     
  Branches    25076    25140      +64     
==========================================
  Hits        10942    10942              
- Misses      70543    70641      +98     
  Partials    11475    11475              
Flag Coverage Δ *Carryforward flag
differential 6.11% <0.00%> (?)
total 11.78% <ø> (+0.01%) ⬆️ Carriedforward from 46e6315

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...r/scene_module/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...planner/scene_module/avoidance/avoidance_utils.hpp 0.00% <0.00%> (ø)
...th_planner/scene_module/scene_module_interface.hpp 0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/avoidance/avoidance_utils.cpp 0.76% <0.00%> (-0.24%) ⬇️
...er/include/scene_module/scene_module_interface.hpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 force-pushed the fix/drivable-area-with-static-obstacles branch from eb677ea to 2f6b217 Compare February 22, 2023 01:41
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the fix/drivable-area-with-static-obstacles branch from 2f6b217 to 331542c Compare February 22, 2023 02:14
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Additional note 1:
Function is checked and worked as expected.
As of this PR is tested, the following flag needs to be set to true

enable_bound_clipping
disable_path_update

Additional note 2:
avoidance still will not work when the the function is enable, but it will be solve in the near future.

@takayuki5168 takayuki5168 merged commit 55dc662 into autowarefoundation:main Feb 22, 2023
@takayuki5168 takayuki5168 deleted the fix/drivable-area-with-static-obstacles branch February 22, 2023 03:52
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
…warefoundation#2880)

* drivable area with static obstacles

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix build error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…warefoundation#2880)

* drivable area with static obstacles

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix build error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants