-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): drivable area with static obstacles #2880
fix(behavior_path_planner): drivable area with static obstacles #2880
Conversation
6b1a655
to
eb677ea
Compare
Codecov ReportBase: 11.77% // Head: 11.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2880 +/- ##
==========================================
- Coverage 11.77% 11.75% -0.02%
==========================================
Files 1324 1325 +1
Lines 92960 93058 +98
Branches 25076 25140 +64
==========================================
Hits 10942 10942
- Misses 70543 70641 +98
Partials 11475 11475
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_utils.cpp
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_utils.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_utils.cpp
Show resolved
Hide resolved
...havior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_utils.hpp
Show resolved
Hide resolved
eb677ea
to
2f6b217
Compare
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
2f6b217
to
331542c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Additional note 1:
Function is checked and worked as expected.
As of this PR is tested, the following flag needs to be set to true
enable_bound_clipping
disable_path_update
Additional note 2:
avoidance still will not work when the the function is enable, but it will be solve in the near future.
…warefoundation#2880) * drivable area with static obstacles Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix build error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…warefoundation#2880) * drivable area with static obstacles Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix build error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Description
This includes the change of #2852
dealt with complicated static obstacles
rough sketch of the algorithm on this PR.
![image](https://user-images.githubusercontent.com/20228327/218805764-d46cda98-a27b-4360-a2a0-375ba8b75013.png)
case1
![image](https://user-images.githubusercontent.com/20228327/218803268-f663455e-9cb9-498c-88c5-0b7f8a2781c9.png)
![image](https://user-images.githubusercontent.com/20228327/218804568-fac36b54-0e12-49e8-8c55-af6445794e81.png)
before
after
case2
![image](https://user-images.githubusercontent.com/20228327/218803382-86a8bab9-81bc-4ad9-aa1e-75cf1dddd5f0.png)
![image](https://user-images.githubusercontent.com/20228327/218804740-f0696bb5-1831-4b58-b7da-28a90a704712.png)
before
after
case3
![image](https://user-images.githubusercontent.com/20228327/218803702-8945cdb2-c411-4378-aa12-01b8b6c00015.png)
![image](https://user-images.githubusercontent.com/20228327/218805056-33b90ecc-7c52-49f8-99a2-24ae2a1292a8.png)
before
after
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.