Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detected_object_validator): parameterize validator threshold for each label #2866

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 10, 2023

Description

This PR add parameter for min_pointcloud_num in obstacle_pointcloud_based_validator which is hardcoded in validator node file. For small categories this value can be set to a smaller one than the current value of 10.

Tests performed

WIP

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 10, 2023
@soblin soblin changed the title Feat/parameterize validator threshold label feat(detected_object_validator): parameterize validator threshold for each label Feb 10, 2023
@soblin
Copy link
Contributor Author

soblin commented Feb 23, 2023

#2894

@soblin soblin closed this Mar 23, 2023
@soblin soblin deleted the feat/parameterize-validator-threshold-label branch April 24, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant