Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): fix z of extracted drivable area #2856

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 9, 2023

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

When the object is extracted from the drivable area, its z is set wrong.

before
image

after
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 9, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review February 9, 2023 16:12
@takayuki5168
Copy link
Contributor Author

@purewater0901 Could you review the PR.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 11.62% // Head: 11.58% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (996818b) compared to base (ff9d064).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2856      +/-   ##
==========================================
- Coverage   11.62%   11.58%   -0.04%     
==========================================
  Files        1321     1321              
  Lines       92142    92443     +301     
  Branches    24446    24642     +196     
==========================================
  Hits        10712    10712              
- Misses      70249    70536     +287     
- Partials    11181    11195      +14     
Flag Coverage Δ *Carryforward flag
differential 4.67% <0.00%> (?)
total 11.62% <ø> (ø) Carriedforward from ff9d064

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/src/scene_module/avoidance/avoidance_utils.cpp 1.00% <0.00%> (-0.01%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 7.65% <0.00%> (-0.34%) ⬇️
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 9c632a5 into autowarefoundation:main Feb 10, 2023
@takayuki5168 takayuki5168 deleted the fix/drivable-area-extraction-z branch February 10, 2023 01:08
KYabuuchi pushed a commit to KYabuuchi/autoware.universe that referenced this pull request Feb 16, 2023
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants