-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map_based_prediction): update lane change decision logic #2822
feat(map_based_prediction): update lane change decision logic #2822
Conversation
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Codecov ReportBase: 11.54% // Head: 11.50% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2822 +/- ##
==========================================
- Coverage 11.54% 11.50% -0.05%
==========================================
Files 1309 1309
Lines 91355 91676 +321
Branches 24247 24247
==========================================
Hits 10547 10547
- Misses 69766 70087 +321
Partials 11042 11042
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
perception/map_based_prediction/include/map_based_prediction/map_based_prediction_node.hpp
Show resolved
Hide resolved
perception/map_based_prediction/include/map_based_prediction/map_based_prediction_node.hpp
Outdated
Show resolved
Hide resolved
Old parameters in config file should be updated either. -> fixed in e746228. |
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…refoundation#2822) * update lane change decision logic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * hold lateral kinematics of each lanelet in objdata Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * calc lateral_kinematics in objecthistory creation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * using lateral kinematics in LC decision Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix left/right typo Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * avoid zero division Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * Fixed lose reference bug Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * refactor some comments and processes Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * update rosparam config file and declaration Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * add cutoff freq usage Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * use map to handle lateral kinematics Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…refoundation#2822) * update lane change decision logic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * hold lateral kinematics of each lanelet in objdata Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * calc lateral_kinematics in objecthistory creation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * using lateral kinematics in LC decision Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix left/right typo Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * avoid zero division Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * Fixed lose reference bug Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * refactor some comments and processes Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * update rosparam config file and declaration Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * add cutoff freq usage Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * use map to handle lateral kinematics Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…refoundation#2822) * update lane change decision logic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * hold lateral kinematics of each lanelet in objdata Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * calc lateral_kinematics in objecthistory creation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * using lateral kinematics in LC decision Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix left/right typo Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * avoid zero division Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * Fixed lose reference bug Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * refactor some comments and processes Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * update rosparam config file and declaration Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * add cutoff freq usage Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * use map to handle lateral kinematics Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri yoshiyoshidetteiu@gmail.com
Description
Try to update lane change decision logic.
New logic uses following information as decision threshold.
Actual LC decision fires when:
Related Internal links
Tests performed
This method uses low-pass filtered lateral speed so that it prevents chattering and gives more stable prediction.
Both filter cut-off and time margin are decided by analyzing real lane changing data.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.