-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(motion_velocity_smoother): remove unneccesary optional #2811
refactor(motion_velocity_smoother): remove unneccesary optional #2811
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Codecov ReportBase: 11.61% // Head: 11.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2811 +/- ##
==========================================
- Coverage 11.61% 11.58% -0.03%
==========================================
Files 1319 1319
Lines 92085 92313 +228
Branches 24408 24492 +84
==========================================
Hits 10692 10692
- Misses 70227 70450 +223
- Partials 11166 11171 +5
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b236f30
to
a20c7af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…warefoundation#2811) * remove optional for lateral acc filter Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * apply to behavior_velocity_planner Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
The boost::optional for filters used in the
motion_velocuty_smoother
gets none only when the path is empty.This PR moves the empty check out of the filters and changes the return value to the actual value.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.