fix(accel_brake_map_calibrator): set method to none as default in view plot py #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w plot py Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Codecov ReportBase: 11.63% // Head: 11.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2808 +/- ##
=======================================
Coverage 11.63% 11.63%
=======================================
Files 1318 1318
Lines 91883 91883
Branches 24407 24407
=======================================
Hits 10691 10691
Misses 70025 70025
Partials 11167 11167
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
asana17
pushed a commit
to asana17/autoware.universe
that referenced
this pull request
Feb 8, 2023
…w plot py (autowarefoundation#2808) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
KYabuuchi
pushed a commit
to KYabuuchi/autoware.universe
that referenced
this pull request
Feb 16, 2023
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp
Description
Currently, the default value of args.method is not None but "None".
So, None-check for
calibration_methodis not properly performed, and unnecessary errors are occured. I fixed it.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.