-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lanelet2_map_loader): delete unused parameters #2761
Conversation
Codecov ReportBase: 11.64% // Head: 11.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2761 +/- ##
=======================================
Coverage 11.64% 11.64%
=======================================
Files 1312 1312
Lines 91430 91430
Branches 24327 24327
=======================================
Hits 10646 10646
Misses 69668 69668
Partials 11116 11116
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n#2761) * fix(lanelet2_map_loader): delete unused parameters * Update lanelet2_map_loader.launch.xml
…n#2761) * fix(lanelet2_map_loader): delete unused parameters * Update lanelet2_map_loader.launch.xml Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
…n#2761) * fix(lanelet2_map_loader): delete unused parameters * Update lanelet2_map_loader.launch.xml
…n#2761) * fix(lanelet2_map_loader): delete unused parameters * Update lanelet2_map_loader.launch.xml
Description
In #954, I added following parameters in
lanelet2_map_loader.param.yaml
.However, I forget to delete from lanelet2_map_loader.launch.xml.
I fix it.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.