Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): add option for combining arc pull out paths #2669

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 17, 2023

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

Add option for combining two arc paths of pull_out. This eliminates stops along the way.

pull_out_arc_path-2023-01-17_17.29.00.mp4

Related links

tier4 internal link

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 17, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/pull_out_no_stop_arc branch from f6b51ec to 18ce9af Compare January 17, 2023 10:07
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cap-.2023-01-17-19-23-56.mp4.mp4

LGTM

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 11.38% // Head: 11.36% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (18ce9af) compared to base (2eafda6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2669      +/-   ##
==========================================
- Coverage   11.38%   11.36%   -0.03%     
==========================================
  Files        1277     1277              
  Lines       89230    89444     +214     
  Branches    23619    23766     +147     
==========================================
+ Hits        10160    10161       +1     
- Misses      68297    68497     +200     
- Partials    10773    10786      +13     
Flag Coverage Δ *Carryforward flag
differential 4.94% <0.00%> (?)
total 11.38% <0.00%> (ø) Carriedforward from 2eafda6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.26% <0.00%> (+0.10%) ⬆️
...r/src/scene_module/pull_out/geometric_pull_out.cpp 0.00% <0.00%> (ø)
...anner/src/scene_module/pull_over/goal_searcher.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 19bba84 into main Jan 17, 2023
@kosuke55 kosuke55 deleted the feat/pull_out_no_stop_arc branch January 17, 2023 12:01
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jan 17, 2023
…ths (autowarefoundation#2669)

* feat(behavior_path_planner): add option for combining arc pull out paths

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* divide_pull_out_path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Jan 17, 2023
* feat(behavior_path_planner): ignore pull over goal near lane start (autowarefoundation#2667)

feat(behavior_path_planner) ignore pull over goal near lane start

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(behavior_path_planner): add option for combining arc pull out paths (autowarefoundation#2669)

* feat(behavior_path_planner): add option for combining arc pull out paths

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* divide_pull_out_path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…ths (autowarefoundation#2669)

* feat(behavior_path_planner): add option for combining arc pull out paths

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* divide_pull_out_path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants