Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pose_initializer): add default ad api description in readme #2635

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 11, 2023

Signed-off-by: kminoda koji.minoda@tier4.jp

Description

Update readme for better understandability

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda requested review from isamu-takagi, YamatoAndo and a team as code owners January 11, 2023 09:05
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Jan 11, 2023
@kminoda kminoda self-assigned this Jan 11, 2023
@@ -0,0 +1,553 @@
<svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@kminoda kminoda Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I could not come up with a better idea than referring to the file by relative path like this: 7458203.
I am glad if you could tell me if have any better idea.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know it's the only way. The svg file is no longer needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thank you. Fixed: f0001b1

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 11.49% // Head: 11.49% // No change to project coverage 👍

Coverage data is based on head (7458203) compared to base (316f5e9).
Patch has no changes to coverable lines.

❗ Current head 7458203 differs from pull request most recent head f0001b1. Consider uploading reports for the commit f0001b1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2635   +/-   ##
=======================================
  Coverage   11.49%   11.49%           
=======================================
  Files        1271     1271           
  Lines       88412    88412           
  Branches    23314    23314           
=======================================
  Hits        10164    10164           
  Misses      67476    67476           
  Partials    10772    10772           
Flag Coverage Δ *Carryforward flag
differential 5.76% <ø> (?)
total 11.49% <ø> (ø) Carriedforward from 316f5e9

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit d01b453 into autowarefoundation:main Jan 12, 2023
@kminoda kminoda deleted the chore/pose_initializer/update_readme branch August 10, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants