-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pose_initializer): add default ad api description in readme #2635
fix(pose_initializer): add default ad api description in readme #2635
Conversation
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@@ -0,0 +1,553 @@ | |||
<svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original file is here so please refer to it directly instead of copying it.
https://github.com/autowarefoundation/autoware.universe/blob/main/system/default_ad_api/document/images/localization.drawio.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I could not come up with a better idea than referring to the file by relative path like this: 7458203.
I am glad if you could tell me if have any better idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know it's the only way. The svg file is no longer needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thank you. Fixed: f0001b1
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Codecov ReportBase: 11.49% // Head: 11.49% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2635 +/- ##
=======================================
Coverage 11.49% 11.49%
=======================================
Files 1271 1271
Lines 88412 88412
Branches 23314 23314
=======================================
Hits 10164 10164
Misses 67476 67476
Partials 10772 10772
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: kminoda koji.minoda@tier4.jp
Description
Update readme for better understandability
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.