Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pure_pursuit): update parameter file #2629

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Jan 10, 2023

Signed-off-by: Berkay Karaman brkay54@gmail.com

Description

In pure_pursuit controller, old parameters are deprecated so we need to update.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Berkay Karaman <brkay54@gmail.com>
@brkay54 brkay54 requested a review from TakaHoribe as a code owner January 10, 2023 14:09
@brkay54 brkay54 self-assigned this Jan 10, 2023
@brkay54 brkay54 requested a review from a team as a code owner January 10, 2023 14:09
@brkay54 brkay54 requested a review from takayuki5168 January 10, 2023 14:09
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 12.29% // Head: 12.29% // No change to project coverage 👍

Coverage data is based on head (3fe2591) compared to base (be31385).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2629   +/-   ##
=======================================
  Coverage   12.29%   12.29%           
=======================================
  Files        1171     1171           
  Lines       82654    82654           
  Branches    23317    23317           
=======================================
  Hits        10162    10162           
  Misses      61721    61721           
  Partials    10771    10771           
Flag Coverage Δ *Carryforward flag
differential 13.22% <ø> (?)
total 12.29% <ø> (ø) Carriedforward from be31385

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brkay54 brkay54 merged commit f1714f1 into autowarefoundation:main Jan 11, 2023
@brkay54 brkay54 deleted the update-pure-pursuit-params branch April 27, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants